https://codereview.chromium.org/287893002/diff/20001/build/android.gypi
File build/android.gypi (right):

https://codereview.chromium.org/287893002/diff/20001/build/android.gypi#newcode218
build/android.gypi:218: ['target_arch=="arm64"', {
On 2014/05/14 14:00:33, rmcilroy wrote:
  or 'target_arch'=="x86_64"

Added "x64" to be consistent with other conditions in this file.

android_x64 and android_x68_x64 are not supported in Makefile.android at
the moment.

https://codereview.chromium.org/287893002/diff/20001/build/android.gypi#newcode219
build/android.gypi:219: # TODO(ulan): Enable PIE for other
architectures.
On 2014/05/14 14:00:33, rmcilroy wrote:
nit - you might want to point to crbug.com/373219 here to identify why
we aren't
doing this yet.

Done.

https://codereview.chromium.org/287893002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to