Reviewers: danno, Paul Lind, palfia, dusmil, kisg, m.m.capewell,
Description:
MIPS: Fix FlooringDivByPowerOf2I.
Port r21313 (3b4cb0b)
Original commit message:
Fix for divisor=1, found during code inspection. We can't hit this bug, due
to
HDiv::Canonicalize() discarding the operation, but it might avoid a future
bug
hunt. Patch also includes a small tidying of the ARM64 code.
BUG=
Please review this at https://codereview.chromium.org/277893003/
SVN Base: https://github.com/v8/v8.git@gbl
Affected files (+6, -1 lines):
M src/mips/lithium-codegen-mips.cc
Index: src/mips/lithium-codegen-mips.cc
diff --git a/src/mips/lithium-codegen-mips.cc
b/src/mips/lithium-codegen-mips.cc
index
bb0b358cab20039f24620b39c5ed11fa60b0ffc3..e09feea3ee1322b701aeddec911e75e15a148578
100644
--- a/src/mips/lithium-codegen-mips.cc
+++ b/src/mips/lithium-codegen-mips.cc
@@ -1298,9 +1298,14 @@ void
LCodeGen::DoFlooringDivByPowerOf2I(LFlooringDivByPowerOf2I* instr) {
Register scratch = scratch0();
ASSERT(!scratch.is(dividend));
+ // If the divisor is 1, return the dividend.
+ if (divisor == 1) {
+ __ Move(result, dividend);
+ return;
+ }
+
// If the divisor is positive, things are easy: There can be no deopts
and we
// can simply do an arithmetic right shift.
- if (divisor == 1) return;
uint16_t shift = WhichPowerOf2Abs(divisor);
if (divisor > 1) {
__ sra(result, dividend, shift);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
