LGTM with nits.
https://codereview.chromium.org/273613005/diff/2/tools/testrunner/local/execution.py
File tools/testrunner/local/execution.py (right):
https://codereview.chromium.org/273613005/diff/2/tools/testrunner/local/execution.py#newcode33
tools/testrunner/local/execution.py:33: from . import perfdata
nit: alpha-sort please
https://codereview.chromium.org/273613005/diff/2/tools/testrunner/local/execution.py#newcode97
tools/testrunner/local/execution.py:97: for test in sorted(self.tests,
key=lambda t: t.duration, reverse=True):
Hm... this is used by the network endpoint too, where in most cases the
tests list is already sorted as a result of how the work packets are
assembled. If that turns out to be a performance problem, we'll have to
find a way to skip the double sorting. But for now we can keep it, I
think.
https://codereview.chromium.org/273613005/diff/2/tools/testrunner/network/network_execution.py
File tools/testrunner/network/network_execution.py (right):
https://codereview.chromium.org/273613005/diff/2/tools/testrunner/network/network_execution.py#newcode37
tools/testrunner/network/network_execution.py:37: from ..local import
execution
nit: alpha-sort please
https://codereview.chromium.org/273613005/diff/2/tools/testrunner/network/network_execution.py#newcode58
tools/testrunner/network/network_execution.py:58: # But there is no
super constructor call. Check if this is a problem.
Shouldn't be a problem :-)
Unifying Runner and NetworkedRunner more is a bit tricky due to subtle
interface differences. Feel free to refactor them if you want; I tend to
think that it's not worth the effort.
https://codereview.chromium.org/273613005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
