Reviewers: Michael Achenbach,
Description:
Adapt test expectations in webkit.
[email protected]
Please review this at https://codereview.chromium.org/288163003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+10, -5 lines):
M test/webkit/string-replacement-outofmemory.js
M test/webkit/string-replacement-outofmemory-expected.txt
M test/webkit/webkit.status
Index: test/webkit/string-replacement-outofmemory-expected.txt
diff --git a/test/webkit/string-replacement-outofmemory-expected.txt
b/test/webkit/string-replacement-outofmemory-expected.txt
index
68ac217966064a0f0a69e8f6a17c8a09303f6716..946b248ed6829a9e2e26489bfb8b043b40658106
100644
--- a/test/webkit/string-replacement-outofmemory-expected.txt
+++ b/test/webkit/string-replacement-outofmemory-expected.txt
@@ -21,3 +21,12 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
THIS
# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+This tests that string replacement with a large replacement string causes
an out-of-memory exception. See bug 102956 for more details.
+
+On success, you will see a series of "PASS" messages, followed by "TEST
COMPLETE".
+
+
+PASS x.replace(/\d/g, y) threw exception RangeError: Invalid string length.
+PASS successfullyParsed is true
+
+TEST COMPLETE
Index: test/webkit/string-replacement-outofmemory.js
diff --git a/test/webkit/string-replacement-outofmemory.js
b/test/webkit/string-replacement-outofmemory.js
index
2b8e18a854110a7c81829b2ff1aa551435f294a2..becfdc6a1f69f38e7d28417785b336407438f53d
100644
--- a/test/webkit/string-replacement-outofmemory.js
+++ b/test/webkit/string-replacement-outofmemory.js
@@ -37,5 +37,5 @@ var y = "2";
x = createStringWithRepeatedChar(x, 1 << 12);
y = createStringWithRepeatedChar(y, (1 << 20) + 1);
-shouldThrow("x.replace(/\\d/g, y)", '"Error: Out of memory"');
+shouldThrow("x.replace(/\\d/g, y)", '"RangeError: Invalid string length"');
var successfullyParsed = true;
Index: test/webkit/webkit.status
diff --git a/test/webkit/webkit.status b/test/webkit/webkit.status
index
a6bf845d00d5a964144d160f3a9231d0b2a2ec53..c897fd4385e1e8b45f7cd956ff1c4eea1ceae402
100644
--- a/test/webkit/webkit.status
+++ b/test/webkit/webkit.status
@@ -27,10 +27,6 @@
[
[ALWAYS, {
- # BUG(237872). TODO(bmeurer): Investigate.
- 'string-replacement-outofmemory': [FAIL],
-
-
##############################################################################
# Flaky tests.
# BUG(v8:2989).
'dfg-inline-arguments-become-double': [PASS, FAIL],
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
