Reviewers: mvstanton,
Message:
Committed patchset #1 manually as r21326 (presubmit successful).
Description:
Only allow allocation site lifetime transitions from undicided to tenure or
don't tenure.
BUG=
[email protected]
Committed: https://code.google.com/p/v8/source/detail?r=21326
Please review this at https://codereview.chromium.org/289973002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -1 lines):
M src/objects-inl.h
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index
6c2b5e2c5315f1288108c99f0ff663aa28386b66..1a59dcc1a212077206a35885c0c9353989aafacd
100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -1587,7 +1587,10 @@ inline bool
AllocationSite::DigestPretenuringFeedback() {
static_cast<double>(found_count) / create_count : 0.0;
PretenureFlag current_mode = GetPretenureMode();
- if (minimum_mementos_created) {
+ // TODO(hpayer): Add an intermediate state MAYBE_TENURE which collects
+ // more lifetime feedback for tenuring candidates. In the meantime, we
+ // just allow transitions from undecided to tenured or not tenured.
+ if (minimum_mementos_created && pretenure_decision() == kUndecided) {
PretenureDecision result = ratio >= kPretenureRatio
? kTenure
: kDontTenure;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
