Reviewers: Michael Achenbach,
Message:
PTAL.
Description:
Move check for existence of generated tests from run-tests.py to
presubmit.py
Inspired by https://codereview.chromium.org/275143002#msg3
Please review this at https://codereview.chromium.org/290023002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+11, -7 lines):
M tools/presubmit.py
M tools/run-tests.py
Index: tools/presubmit.py
diff --git a/tools/presubmit.py b/tools/presubmit.py
index
7961156b7ae8b5a8f3b123efabcd4343079c3931..a4ca39980522fbdbfe40527b90cd825520ceec62
100755
--- a/tools/presubmit.py
+++ b/tools/presubmit.py
@@ -306,7 +306,8 @@ class SourceProcessor(SourceFileProcessor):
if self.IgnoreDir(dir_part):
break
else:
- if self.IsRelevant(file) and not self.IgnoreFile(file):
+ if (self.IsRelevant(file) and os.path.exists(file)
+ and not self.IgnoreFile(file)):
result.append(join(path, file))
if output.wait() == 0:
return result
@@ -416,6 +417,13 @@ class SourceProcessor(SourceFileProcessor):
return success
+def CheckGeneratedRuntimeTests(workspace):
+ code = subprocess.call(
+ [sys.executable,
join(workspace, "tools", "generate-runtime-tests.py"),
+ "check"])
+ return code == 0
+
+
def GetOptions():
result = optparse.OptionParser()
result.add_option('--no-lint', help="Do not run cpplint", default=False,
@@ -434,6 +442,7 @@ def Main():
print "Running copyright header, trailing whitespaces and " \
"two empty lines between declarations check..."
success = SourceProcessor().Run(workspace) and success
+ success = CheckGeneratedRuntimeTests(workspace) and success
if success:
return 0
else:
Index: tools/run-tests.py
diff --git a/tools/run-tests.py b/tools/run-tests.py
index
6b07574139264778cf116a89bcb43bf583e72841..cfca80f64b7e629062016df38ecab28ada79dc18
100755
--- a/tools/run-tests.py
+++ b/tools/run-tests.py
@@ -336,13 +336,8 @@ def Main():
workspace = os.path.abspath(join(os.path.dirname(sys.argv[0]), ".."))
if not options.no_presubmit:
print ">>> running presubmit tests"
- code = subprocess.call(
+ exit_code = subprocess.call(
[sys.executable, join(workspace, "tools", "presubmit.py")])
- exit_code = code
- code = subprocess.call(
- [sys.executable,
join(workspace, "tools", "generate-runtime-tests.py"),
- "check"])
- exit_code = exit_code or code
suite_paths = utils.GetSuitePaths(join(workspace, "test"))
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
