On 2014/05/15 14:02:44, rossberg wrote:
On 2014/05/15 13:53:36, rossberg wrote:
> lgtm
>
> LGTM.
>
> @Rafael: to expand on Jakob mentioned is that GetCreationContext
Wrong button. :)
@Rafael: to expand on what Jakob said, the GetCreationContext function you
added
assumes that all (JS-side) objects have map()->constructor() set to a
JSFunction. However, it was null for iterators, and we are not quite sure
if
that should be considered a bug with iterators or a bug with
GetCreationContext
(this CL assumes the former as an easy fix). There might be other objects
with
a
null constructor. With proxies, you might even encounter some with a
JSFunctionProxy constructor.
It might be good if you could investigate the uses of map->constructor
throughout the system to figure out what's actually the expected
invariant.
Michael and I skimmed through them briefly, but it wasn't quite obvious.
Note that GetCreationContext() wasn't added by Rafael. It was previously
part of
the V8 API (added in r7476 by antonm as v8::Object::CreationContext());
Rafael
just moved into into v8::internal::JSObject's interface (to avoid
round-tripping
through the API in runtime.cc). So if there are cases where it can fail,
those
failures were already exposed to the embedder.
https://codereview.chromium.org/288233002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
