LGTM, just nits.
https://codereview.chromium.org/290133004/diff/20001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/290133004/diff/20001/src/heap.cc#newcode2059
src/heap.cc:2059: if (FLAG_trace_gc) {
nit: This makes the code harder to read and I am not sure if it actually
has significant profit. Would you be willing to go back to increment
unconditionally here?
https://codereview.chromium.org/290133004/diff/20001/src/heap.cc#newcode2080
src/heap.cc:2080: if (FLAG_trace_gc) {
nit: Likewise.
https://codereview.chromium.org/290133004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
