https://codereview.chromium.org/285693006/diff/1/src/heap.cc
File src/heap.cc (left):
https://codereview.chromium.org/285693006/diff/1/src/heap.cc#oldcode4316
src/heap.cc:4316: void Heap::EnsureHeapIsIterable() {
On 2014/05/18 18:25:43, Hannes Payer wrote:
Let's rename it to MakeIterable.
Done.
https://codereview.chromium.org/285693006/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/285693006/diff/1/src/runtime.cc#newcode13149
src/runtime.cc:13149:
heap->CollectAllGarbage(Heap::kMakeHeapIterableMask,
"%DebugConstructedBy");
On 2014/05/18 18:25:43, Hannes Payer wrote:
Call MakeIterable instead.
I think this should still call CollectAllGarbage because we need the
garbage collection to discard dead objects. MakeHeapIterable does not
guarantee there will be GC.
https://codereview.chromium.org/285693006/diff/1/src/runtime.cc#newcode13225
src/runtime.cc:13225:
heap->CollectAllGarbage(Heap::kMakeHeapIterableMask,
"%DebugConstructedBy");
On 2014/05/18 18:25:43, Hannes Payer wrote:
Call MakeIterable instead.
See above.
https://codereview.chromium.org/285693006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
