PTAL
https://codereview.chromium.org/290173003/diff/20001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/290173003/diff/20001/src/hydrogen-instructions.h#newcode5725
src/hydrogen-instructions.h:5725: // is the new space dominator and the
value is not in new space.
On 2014/05/18 18:54:58, Hannes Payer wrote:
new_space_dominator should be called dominator, otherwise the code
does not fit
the description. Moreover the part about the new space dominator
should be
mentioned earlier.
Done.
https://codereview.chromium.org/290173003/diff/20001/src/hydrogen-instructions.h#newcode5730
src/hydrogen-instructions.h:5730: // allocated in old space.
On 2014/05/18 18:54:58, Hannes Payer wrote:
broken comment.
Done.
https://codereview.chromium.org/290173003/diff/20001/src/hydrogen-instructions.h#newcode5737
src/hydrogen-instructions.h:5737: }
On 2014/05/18 18:54:58, Hannes Payer wrote:
Why not
if (value->IsAllocate() &&
(HAllocate::cast(value)->IsOldDataSpaceAllocation() ||
HAllocate::cast(value)->IsOldPointerSpaceAllocation())
Done.
https://codereview.chromium.org/290173003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
