https://codereview.chromium.org/290633010/diff/1/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/290633010/diff/1/src/heap.h#newcode186
src/heap.h:186: V(JSObject, observation_state, ObservationState)
\
On 2014/05/16 17:41:51, dcarney wrote:
unrelated, but is this another context leak?
My reading of the code suggests it's not: Factory::NewMap() returns a
map with a null |constructor| field, so the JSObject that's put into
observation_state doesn't leak the context via its constructor (but it
does lead to further questions about whether "creation context" is a
meaningful thing for all objects).
https://codereview.chromium.org/290633010/diff/1/src/isolate.cc
File src/isolate.cc (right):
https://codereview.chromium.org/290633010/diff/1/src/isolate.cc#newcode2254
src/isolate.cc:2254: queue = factory()->NewFixedArray(1);
On 2014/05/17 06:54:09, dcarney wrote:
1 might be a little conservative here, maybe 4, 8 or whatever -
depending on
what you see in the wild
Let's go with 8.
https://codereview.chromium.org/290633010/diff/1/src/isolate.cc#newcode2273
src/isolate.cc:2273: while (pending_microtask_count() > 0) {
On 2014/05/16 17:41:51, dcarney wrote:
put handlescope here
Done.
https://codereview.chromium.org/290633010/diff/1/src/isolate.cc#newcode2280
src/isolate.cc:2280: for (int i = 0; i < num_tasks; i++) {
On 2014/05/16 17:41:51, dcarney wrote:
and here maybe
Done.
https://codereview.chromium.org/290633010/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
