Reviewers: Hannes Payer,

Description:
Relax assertion in StoreBuffer::FindPointersToNewSpaceInMapsRegion

Since r21232, maps are now a non-power-of-two size and thus don't fit
evenly into a page.  No test case, as it is somewhat difficult to get
this condition to trigger.  It is possible with this case, however:

    var result;

    (function() {
        for (var i = 0; i < 1e7; i++) {
            result = (function*() { yield 1; })();
            result.foo = 1;
        }
    })();

[email protected]
BUG=

Please review this at https://codereview.chromium.org/291913002/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+0, -1 lines):
  M src/store-buffer.cc


Index: src/store-buffer.cc
diff --git a/src/store-buffer.cc b/src/store-buffer.cc
index 547359a09d50d8a33c70b73fdb3e3b3085480572..ab1323231dd5bffde33a14cd706f951b93472704 100644
--- a/src/store-buffer.cc
+++ b/src/store-buffer.cc
@@ -448,7 +448,6 @@ void StoreBuffer::FindPointersToNewSpaceInMapsRegion(
   Address map_aligned_end   = MapEndAlign(end);

   ASSERT(map_aligned_start == start);
-  ASSERT(map_aligned_end == end);

   FindPointersToNewSpaceInMaps(map_aligned_start,
                                map_aligned_end,


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to