I don't see the platform #ifdef/#include proliferation as a problem for
landing
this, but I agree with Sven that it would sure be nice to clean it up
later, but
that's outside the scope of this CL.
https://codereview.chromium.org/293743005/diff/1/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/293743005/diff/1/src/code-stubs-hydrogen.cc#newcode336
src/code-stubs-hydrogen.cc:336: #if !defined(V8_TARGET_ARCH_X87)
On 2014/05/20 05:44:02, Weiliang wrote:
x87 is more easy to spill the double register, so disable it.
Yes, this platform-specific define here is a no-go. This is a good
example why we removed the x87 port in the first place, precisely
because it is more work to ensure that there is no frame generated on
performance-sensitive stubs, and since x87 ins't a core platform, it
wasn't worth investing the effort. In any case, you'll need to solve
this in a platform independent way, e.g. fixing the x87 register
allocator to avoid having to generate the frame.
https://codereview.chromium.org/293743005/diff/1/src/x87/OWNERS
File src/x87/OWNERS (right):
https://codereview.chromium.org/293743005/diff/1/src/x87/OWNERS#newcode1
src/x87/OWNERS:1: [email protected]
OWNERS must also be committers. Is it reasonable to add Haitao here
instead? He would then be the reviewer for subsequent CLs.
https://codereview.chromium.org/293743005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
