Revision: 21379
Author: [email protected]
Date: Tue May 20 09:13:26 2014 UTC
Log: Tighten HAS_PRIVATE to own properties
[email protected]
BUG=
Review URL: https://codereview.chromium.org/290373002
http://code.google.com/p/v8/source/detail?r=21379
Modified:
/branches/bleeding_edge/src/macros.py
=======================================
--- /branches/bleeding_edge/src/macros.py Thu Apr 17 17:45:32 2014 UTC
+++ /branches/bleeding_edge/src/macros.py Tue May 20 09:13:26 2014 UTC
@@ -166,10 +166,12 @@
macro JSON_NUMBER_TO_STRING(arg) = ((%_IsSmi(%IS_VAR(arg)) || arg - arg ==
0) ? %_NumberToString(arg) : "null");
# Private names.
+# GET_PRIVATE should only be used if the property is known to exists on obj
+# itself (it should really use %GetOwnProperty, but that would be way
slower).
macro GLOBAL_PRIVATE(name) = (%CreateGlobalPrivateSymbol(name));
macro NEW_PRIVATE(name) = (%CreatePrivateSymbol(name));
macro IS_PRIVATE(sym) = (%SymbolIsPrivate(sym));
-macro HAS_PRIVATE(obj, sym) = (sym in obj);
+macro HAS_PRIVATE(obj, sym) = (%HasLocalProperty(obj, sym));
macro GET_PRIVATE(obj, sym) = (obj[sym]);
macro SET_PRIVATE(obj, sym, val) = (obj[sym] = val);
macro DELETE_PRIVATE(obj, sym) = (delete obj[sym]);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
