On 2014/05/19 08:31:12, Hannes Payer wrote:
LGTM
https://codereview.chromium.org/285693006/diff/20001/src/heap.cc
File src/heap.cc (left):
https://codereview.chromium.org/285693006/diff/20001/src/heap.cc#oldcode4312
src/heap.cc:4312: !old_data_space()->was_swept_conservatively());
Now I am not sure if we should remove that method. Why don't we keep it
and
add
new_space()->top() == new_space->bottom(). This would be very
conservative. I
leave that up to you.
https://codereview.chromium.org/285693006/diff/20001/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/285693006/diff/20001/src/heap.h#newcode767
src/heap.h:767: void MakeHeapIterable();
I would call it MakeIterable, since it is a method on heap.
As you suggested, I have resurrected IsHeapIterable and made it require
that the
new space is empty.
I have also moved the DisallowHeapAllocation gadget and the MakeHeapIterable
call to the HeapIterator class.
https://codereview.chromium.org/285693006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
