[v8-dev] [v8] r21391 committed - Remove unused thread locals from debugger....

Tue, 20 May 2014 08:21:46 -0700 

Revision: 21391
Author:   [email protected]
Date:     Tue May 20 15:20:02 2014 UTC
Log:      Remove unused thread locals from debugger.

[email protected]

Review URL: https://codereview.chromium.org/286903003
http://code.google.com/p/v8/source/detail?r=21391

Modified:
 /branches/bleeding_edge/src/arm/frames-arm.h
 /branches/bleeding_edge/src/arm64/frames-arm64.h
 /branches/bleeding_edge/src/debug.cc
 /branches/bleeding_edge/src/debug.h
 /branches/bleeding_edge/src/ia32/frames-ia32.h
 /branches/bleeding_edge/src/mips/frames-mips.h
 /branches/bleeding_edge/src/x64/frames-x64.h

=======================================
--- /branches/bleeding_edge/src/arm/frames-arm.h Tue Apr 29 06:42:26 2014 UTC +++ /branches/bleeding_edge/src/arm/frames-arm.h Tue May 20 15:20:02 2014 UTC 
@@ -29,8 +29,6 @@

 const int kNumJSCallerSaved = 4;

-typedef Object* JSCallerSavedBuffer[kNumJSCallerSaved];
-
// Return the code of the n-th caller-saved register available to JavaScript 
 // e.g. JSCallerSavedReg(0) returns r0.code() == 0
 int JSCallerSavedCode(int n);
=======================================
--- /branches/bleeding_edge/src/arm64/frames-arm64.h Tue Apr 29 06:42:26 2014 UTC +++ /branches/bleeding_edge/src/arm64/frames-arm64.h Tue May 20 15:20:02 2014 UTC 
@@ -15,7 +15,6 @@
 // Registers x0-x17 are caller-saved.
 const int kNumJSCallerSaved = 18;
 const RegList kJSCallerSaved = 0x3ffff;
-typedef Object* JSCallerSavedBuffer[kNumJSCallerSaved];

 // Number of registers for which space is reserved in safepoints. Must be a
 // multiple of eight.
=======================================
--- /branches/bleeding_edge/src/debug.cc        Tue May 20 14:03:38 2014 UTC
+++ /branches/bleeding_edge/src/debug.cc        Tue May 20 15:20:02 2014 UTC
@@ -40,7 +40,6 @@
       promise_catch_handlers_(0),
       promise_getters_(0),
       isolate_(isolate) {
-  memset(registers_, 0, sizeof(JSCallerSavedBuffer));
   ThreadInit();
 }

@@ -518,10 +517,7 @@
 char* Debug::ArchiveDebug(char* storage) {
   char* to = storage;
OS::MemCopy(to, reinterpret_cast<char*>(&thread_local_), sizeof(ThreadLocal)); 
-  to += sizeof(ThreadLocal);
- OS::MemCopy(to, reinterpret_cast<char*>(&registers_), sizeof(registers_)); 
   ThreadInit();
-  ASSERT(to <= storage + ArchiveSpacePerThread());
   return storage + ArchiveSpacePerThread();
 }

@@ -530,15 +526,12 @@
   char* from = storage;
   OS::MemCopy(
       reinterpret_cast<char*>(&thread_local_), from, sizeof(ThreadLocal));
-  from += sizeof(ThreadLocal);
- OS::MemCopy(reinterpret_cast<char*>(&registers_), from, sizeof(registers_)); 
-  ASSERT(from <= storage + ArchiveSpacePerThread());
   return storage + ArchiveSpacePerThread();
 }


 int Debug::ArchiveSpacePerThread() {
-  return sizeof(ThreadLocal) + sizeof(JSCallerSavedBuffer);
+  return sizeof(ThreadLocal);
 }


=======================================
--- /branches/bleeding_edge/src/debug.h Tue May 20 08:52:42 2014 UTC
+++ /branches/bleeding_edge/src/debug.h Tue May 20 15:20:02 2014 UTC
@@ -349,11 +349,6 @@
     Object*** address = &thread_local_.restarter_frame_function_pointer_;
     return reinterpret_cast<Address*>(address);
   }
-
- // Support for saving/restoring registers when handling debug break calls. 
-  Object** register_address(int r) {
-    return &registers_[r];
-  }

   static const int kEstimatedNofDebugInfoEntries = 16;
   static const int kEstimatedNofBreakPointsInFunction = 16;
@@ -586,7 +581,6 @@
   };

   // Storage location for registers when handling debug break calls
-  JSCallerSavedBuffer registers_;
   ThreadLocal thread_local_;
   void ThreadInit();

=======================================
--- /branches/bleeding_edge/src/ia32/frames-ia32.h Tue Apr 29 06:42:26 2014 UTC +++ /branches/bleeding_edge/src/ia32/frames-ia32.h Tue May 20 15:20:02 2014 UTC 
@@ -24,8 +24,6 @@

 const int kNumJSCallerSaved = 5;

-typedef Object* JSCallerSavedBuffer[kNumJSCallerSaved];
-

 // Number of registers for which space is reserved in safepoints.
 const int kNumSafepointRegisters = 8;
=======================================
--- /branches/bleeding_edge/src/mips/frames-mips.h Tue Apr 29 06:42:26 2014 UTC +++ /branches/bleeding_edge/src/mips/frames-mips.h Tue May 20 15:20:02 2014 UTC 
@@ -87,8 +87,6 @@
 const int kNumSafepointSavedRegisters =
     kNumJSCallerSaved + kNumCalleeSaved;

-typedef Object* JSCallerSavedBuffer[kNumJSCallerSaved];
-
 const int kUndefIndex = -1;
 // Map with indexes on stack that corresponds to codes of saved registers.
 const int kSafepointRegisterStackIndexMap[kNumRegs] = {
=======================================
--- /branches/bleeding_edge/src/x64/frames-x64.h Wed Apr 30 09:12:18 2014 UTC +++ /branches/bleeding_edge/src/x64/frames-x64.h Tue May 20 15:20:02 2014 UTC 
@@ -18,8 +18,6 @@

 const int kNumJSCallerSaved = 5;

-typedef Object* JSCallerSavedBuffer[kNumJSCallerSaved];
-
 // Number of registers for which space is reserved in safepoints.
 const int kNumSafepointRegisters = 16;

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to