Reviewers: Michael Starzinger,
Message:
Committed patchset #1 manually as r21409 (tree was closed).
Description:
Fix OrderedHashSet::Remove caller in debug-only code after r21408
[email protected]
Committed: https://code.google.com/p/v8/source/detail?r=21409
Please review this at https://codereview.chromium.org/294473011/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -1 lines):
M test/cctest/test-dictionary.cc
Index: test/cctest/test-dictionary.cc
diff --git a/test/cctest/test-dictionary.cc b/test/cctest/test-dictionary.cc
index
aa1bc8623182fb9553d43cb4ad85b263ccadc4a2..fc2227f349beacee0853d0e283d6b8404d706e55
100644
--- a/test/cctest/test-dictionary.cc
+++ b/test/cctest/test-dictionary.cc
@@ -187,7 +187,9 @@ static void TestHashSetCausesGC(Handle<HashSet> table) {
CHECK(gc_count == isolate->heap()->gc_count());
// Calling Remove() will not cause GC in this case.
- table = HashSet::Remove(table, key);
+ bool was_present = false;
+ table = HashSet::Remove(table, key, &was_present);
+ CHECK(!was_present);
CHECK(gc_count == isolate->heap()->gc_count());
// Calling Add() should cause GC.
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
