LGTM with qualms -- IMO, instead of starting to turn random functions into
macros just for the sake of visibility, the more scalable and more robust
approach would be to change the JS code such that by default, a function
does
not end up in the builtin object, i.e., by putting everything into a block.
Then
only selected functions would be -- explicitly -- "exported" to a global
variable, and others are kept local by construction. (Notably, that would
make
addressing both the troubling functions in this CL moot.)
https://codereview.chromium.org/292173011/diff/20001/src/uri.js
File src/uri.js (right):
https://codereview.chromium.org/292173011/diff/20001/src/uri.js#newcode89
src/uri.js:89: macro URI_DECODE_OCTETS(OCTETS, RESULT, INDEX)
Let's at least add a comment that explains why this was done, and a TODO
with the plan to replace it with a scalable solution.
https://codereview.chromium.org/292173011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
