On 2014/05/21 14:35:52, rossberg wrote:
https://codereview.chromium.org/297513006/diff/1/src/mirror-debugger.js
File src/mirror-debugger.js (right):
https://codereview.chromium.org/297513006/diff/1/src/mirror-debugger.js#newcode603
src/mirror-debugger.js:603: SymbolMirror.prototype.name = function() {
Let's call it description -- that's the term the spec uses.
Changed to description
https://codereview.chromium.org/297513006/diff/1/src/mirror-debugger.js#newcode609
src/mirror-debugger.js:609: return 'Symbol "' + this.name() + '"';
I'd put parens around the string, so it looks like the constructor call.
Changed to simply use SymbolToString
https://codereview.chromium.org/297513006/diff/1/src/mirror-debugger.js#newcode2358
src/mirror-debugger.js:2358: o.value = mirror.name();
Should this have been .name on the LHS?
Changed to .description
https://codereview.chromium.org/297513006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
