Reviewers: rossberg, ulan,
https://codereview.chromium.org/231073002/diff/920001/src/parser-symbol-table.cc
File src/parser-symbol-table.cc (right):
https://codereview.chromium.org/231073002/diff/920001/src/parser-symbol-table.cc#newcode57
src/parser-symbol-table.cc:57: if (string1->hash != string2->hash)
return false;
On 2014/05/21 15:01:22, ulan wrote:
I think HashMap guarantees that the hashes are equal upon calling this
function.
Actually, not. Turns out this case is sometimes hit. (We might bucket
elements with different hash functions together. Which is good. We don't
want to have a 2^32 element hash array or anything like that.)
Description:
WIP: Parser: delay string internalization.
This is so that the Parser can be ran on a background thread.
BUG=
Please review this at https://codereview.chromium.org/231073002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1265, -577 lines):
M src/ast.h
M src/ast.cc
M src/compiler.h
M src/compiler.cc
M src/func-name-inferrer.h
M src/func-name-inferrer.cc
M src/interface.h
M src/interface.cc
M src/list.h
M src/parser.h
M src/parser.cc
A src/parser-symbol-table.h
A src/parser-symbol-table.cc
M src/preparser.h
M src/prettyprinter.h
M src/prettyprinter.cc
M src/rewriter.cc
M src/scanner.h
M src/scanner.cc
M src/scopeinfo.cc
M src/scopes.h
M src/scopes.cc
M src/utils.h
M src/variables.h
M src/variables.cc
M test/cctest/test-parsing.cc
M tools/gyp/v8.gyp
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
