https://codereview.chromium.org/290013004/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/290013004/diff/1/src/heap-snapshot-generator.cc#newcode856
src/heap-snapshot-generator.cc:856: return AddEntry(object,
HeapEntry::kSymbol, "Symbol");
On 2014/05/22 09:16:51, Yang wrote:
We seem to use lower case string throughout this method, like "number"
for heap
numbers. So maybe we should use lower case here too?
I'd rather fix those strings so that they match actual type names. But
this should be addressed in a separate change. Changing Symbol->symbol
for consistency for now.
https://codereview.chromium.org/290013004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
