Reviewers: jarin,
Message:
Hi Jaro, here is the issue we discussed, thanks!
--Michael
Description:
GCMole evaluation order issue in CallIC::DoCustomHandler().
Please review this at https://codereview.chromium.org/296693011/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -1 lines):
M src/ic.cc
Index: src/ic.cc
diff --git a/src/ic.cc b/src/ic.cc
index
38a0c149a8378178ac9f1f4f800553e76e9aba8c..90beb36d0dea33301d125f6a383e0c09da0ff776
100644
--- a/src/ic.cc
+++ b/src/ic.cc
@@ -1850,7 +1850,8 @@ bool CallIC::DoCustomHandler(Handle<Object> receiver,
isolate()->context()->native_context()->array_function(), isolate());
if (array_function.is_identical_to(Handle<JSFunction>::cast(function))) {
// Alter the slot.
- vector->set(slot->value(), *isolate()->factory()->NewAllocationSite());
+ Handle<AllocationSite> new_site =
isolate()->factory()->NewAllocationSite();
+ vector->set(slot->value(), *new_site);
State new_state = state.ToMonomorphicArrayCallState();
CallICStub stub(isolate(), new_state);
set_target(*stub.GetCode());
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
