LGTM with comment.
I've only looked at arm, I assume other platforms are identical.
https://codereview.chromium.org/296993002/diff/1/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):
https://codereview.chromium.org/296993002/diff/1/src/arm/lithium-arm.cc#newcode843
src/arm/lithium-arm.cc:843: void
LChunkBuilder::CheckAndAddInstruction(LInstruction* instr,
I'd call this just AddInstruction...
https://codereview.chromium.org/296993002/diff/1/src/arm/lithium-arm.cc#newcode845
src/arm/lithium-arm.cc:845: if (instr != NULL) {
...and move this check to the caller. I don't think other callers need
the flexibility to pass in NULL.
https://codereview.chromium.org/296993002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
