https://codereview.chromium.org/294943009/diff/50001/src/isolate.cc
File src/isolate.cc (right):
https://codereview.chromium.org/294943009/diff/50001/src/isolate.cc#newcode2294
src/isolate.cc:2294: goto done;
DBC: Please, no goto. Either the explicit return or the simple break is
much preferable to me over the goto.
On 2014/05/22 11:49:25, adamk wrote:
On 2014/05/22 11:27:59, Michael Starzinger wrote:
> Pretty please with a cherry on top, no gotos ... shouldn't a simple
break of
the
> for-loop actually implicitly kick you out of the while-loop as well?
Hmm, that seems a bit fragile to me, if someone changes the while loop
later we
might get into trouble. But I'm happy to get rid of the goto.
Instead I've switched to using the SuppressMicrotaskExecutionScope
already
written as part of the V8 API. It's a little weird to use something
from the API
here but I feel weirder writing the same code again just to avoid a
few
reinterpret_casts. Let me know what you think.
https://codereview.chromium.org/294943009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
