https://codereview.chromium.org/251753005/diff/20001/src/types.cc
File src/types.cc (right):
https://codereview.chromium.org/251753005/diff/20001/src/types.cc#newcode468
src/types.cc:468: ASSERT(this->Length() >= 2);
This function always returns true, so the return type should be changed
to void or the ASSERTs should be changed to return false.
https://codereview.chromium.org/251753005/diff/20001/src/types.h
File src/types.h (right):
https://codereview.chromium.org/251753005/diff/20001/src/types.h#newcode374
src/types.h:374: TypeImpl* unhandle() { return this; }
Nit: Can we come up with a better name? "unhandle" is horrible.
https://codereview.chromium.org/251753005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
