lgtm
https://codereview.chromium.org/299173002/diff/1/BUILD.gn
File BUILD.gn (right):
https://codereview.chromium.org/299173002/diff/1/BUILD.gn#newcode114
BUILD.gn:114: if (v8_target_arch == "ia32") {
GN uses x86 for this.
https://codereview.chromium.org/299173002/diff/1/BUILD.gn#newcode136
BUILD.gn:136: "ENABLE_DISASSEMBLER",
Out-dent 2 spaces.
https://codereview.chromium.org/299173002/diff/1/BUILD.gn#newcode840
BUILD.gn:840: defines += ["CAN_USE_VFP_INSTRUCTIONS"]
Spaces inside []
https://codereview.chromium.org/299173002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
