Reviewers: dcarney,
Description:
Always fully qualify the namespace to use in v8.h
Also, remove some unused methods.
BUG=none
[email protected]
LOG=n
Please review this at https://codereview.chromium.org/297223006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -10 lines):
M include/v8.h
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index
bfd3de043821b2ec0033c7d004260b39ca16ca5a..656aa355691a322fb16b1157f2a66b3c1ae04aba
100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -5648,13 +5648,14 @@ class Internals {
return reinterpret_cast<internal::Object**>(addr + index *
kApiPointerSize);
}
- template <typename T> V8_INLINE static T ReadField(Object* ptr, int
offset) {
+ template <typename T>
+ V8_INLINE static T ReadField(internal::Object* ptr, int offset) {
uint8_t* addr = reinterpret_cast<uint8_t*>(ptr) + offset -
kHeapObjectTag;
return *reinterpret_cast<T*>(addr);
}
template <typename T>
- V8_INLINE static T ReadEmbedderData(Context* context, int index) {
+ V8_INLINE static T ReadEmbedderData(v8::Context* context, int index) {
typedef internal::Object O;
typedef internal::Internals I;
O* ctx = *reinterpret_cast<O**>(context);
@@ -5665,14 +5666,6 @@ class Internals {
I::kFixedArrayHeaderSize + (internal::kApiPointerSize * index);
return I::ReadField<T>(embedder_data, value_offset);
}
-
- V8_INLINE static bool CanCastToHeapObject(void* o) { return false; }
- V8_INLINE static bool CanCastToHeapObject(Context* o) { return true; }
- V8_INLINE static bool CanCastToHeapObject(String* o) { return true; }
- V8_INLINE static bool CanCastToHeapObject(Object* o) { return true; }
- V8_INLINE static bool CanCastToHeapObject(Message* o) { return true; }
- V8_INLINE static bool CanCastToHeapObject(StackTrace* o) { return true; }
- V8_INLINE static bool CanCastToHeapObject(StackFrame* o) { return true; }
};
} // namespace internal
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
