Revision: 21496
Author: [email protected]
Date: Mon May 26 13:31:55 2014 UTC
Log: D8 should send idle notification even after the last run.
This, in combination with changes to the bot, should weed out false
negatives.
[email protected]
Review URL: https://codereview.chromium.org/293393003
http://code.google.com/p/v8/source/detail?r=21496
Modified:
/branches/bleeding_edge/src/d8.cc
=======================================
--- /branches/bleeding_edge/src/d8.cc Thu May 22 08:11:10 2014 UTC
+++ /branches/bleeding_edge/src/d8.cc Mon May 26 13:31:55 2014 UTC
@@ -1345,7 +1345,7 @@
{
HandleScope scope(isolate);
Local<Context> context = CreateEvaluationContext(isolate);
- if (options.last_run) {
+ if (options.last_run && options.interactive_shell) {
// Keep using the same context in the interactive shell.
evaluation_context_.Reset(isolate, context);
#ifndef V8_SHARED
@@ -1362,12 +1362,10 @@
options.isolate_sources[0].Execute(isolate);
}
}
- if (!options.last_run) {
- if (options.send_idle_notification) {
- const int kLongIdlePauseInMs = 1000;
- V8::ContextDisposedNotification();
- V8::IdleNotification(kLongIdlePauseInMs);
- }
+ if (options.send_idle_notification) {
+ const int kLongIdlePauseInMs = 1000;
+ V8::ContextDisposedNotification();
+ V8::IdleNotification(kLongIdlePauseInMs);
}
#ifndef V8_SHARED
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
