On 2014/05/27 12:19:55, Michael Starzinger wrote:
LGTM with suggestion.
https://codereview.chromium.org/300753002/diff/20001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/300753002/diff/20001/src/objects.h#newcode5080
src/objects.h:5080: inline int SizeFromMap(Map* map);
nit: Instead of overloading the SizeFromMap() name, can we call this
TypedArraySize() instead? Also it might make sense to consider passing the
InstanceType instead of the map.
Done.
https://codereview.chromium.org/300753002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
