Reviewers: brettw,

Message:
is script = "mksnapshot" enough to make gn build mksnapshot first? And does it
figure out itself that it needs to build mksnapshot for the host arch?

Description:
First cut at run_mksnapshot action for gn

BUG=none
[email protected]
LOG=n

Please review this at https://codereview.chromium.org/293363009/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+24, -0 lines):
  M BUILD.gn


Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index a30f44d66794469dc908fb7b5e1b97b3ede87504..bba76c00337b15538a34c1448b33deb696a4aa80 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -18,6 +18,7 @@ v8_use_default_platform = true
 #v8_use_snapshot = true
 v8_enable_extra_checks = is_debug
 v8_target_arch = cpu_arch
+v8_random_seed = "314159265"


###############################################################################
@@ -255,6 +256,29 @@ action("postmortem-metadata") {
     rebase_path(sources, root_build_dir)
 }

+action("run_mksnapshot") {
+  visibility = ":*"  # Only targets in this file can depend on this.
+
+  script = "mksnapshot"
+
+  outputs = [
+    "$target_gen_dir/snapshot.cc"
+  ]
+
+  args = [
+    "--log-snapshot-positions",
+    "--logfile", "$target_gen_dir/snapshot.log"
+  ]
+
+  if (v8_random_seed != "0") {
+    args += [ "--random-seed", v8_random_seed ]
+  }
+
+  args +=  rebase_path(outputs, root_build_dir)
+
+}
+
+
###############################################################################
 # Source Sets (aka static libraries)
 #


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to