Reviewers: Michael Starzinger,
Description:
Fix check for empty type
[email protected]
BUG=
Please review this at https://codereview.chromium.org/307453005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M src/typing.cc
Index: src/typing.cc
diff --git a/src/typing.cc b/src/typing.cc
index
f32f0eb393d7c6943146371aee5e2f5eca35391e..6a3c94c0f85e240609b28a8a989eab8a2c7832bb
100644
--- a/src/typing.cc
+++ b/src/typing.cc
@@ -675,7 +675,7 @@ void AstTyper::VisitBinaryOperation(BinaryOperation*
expr) {
Bounds l = expr->left()->bounds();
Bounds r = expr->right()->bounds();
Type* lower =
- l.lower->Is(Type::None()) || r.lower->Is(Type::None()) ?
+ !l.lower->IsInhabited() || !r.lower->IsInhabited() ?
Type::None(zone()) :
l.lower->Is(Type::String()) || r.lower->Is(Type::String()) ?
Type::String(zone()) :
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
