On 2014/05/28 08:17:47, danno wrote:
lgtm, although IIRC we have already removed any explicit checks for sahf
support
in the ia32 backend when generating code, so I don't think this change
has
any
effect. However, it does seem to make sense for consistency.
Please fix the indentation nit and I will land this for you.
https://codereview.chromium.org/298823008/diff/1/src/cpu.cc
File src/cpu.cc (right):
https://codereview.chromium.org/298823008/diff/1/src/cpu.cc#newcode304
src/cpu.cc:304: // SAHF is always available in compat/legacy mode,
nit: indentation is off
Fix. I just find that I can remove the check from x87 port. I will submit
another CL to remove it.
Thanks a lot
https://codereview.chromium.org/298823008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
