Reviewers: yurys,
Description:
Remove unused debug API.
[email protected]
Please review this at https://codereview.chromium.org/303693010/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -21 lines):
M include/v8-debug.h
M src/debug.cc
M test/cctest/test-debug.cc
Index: include/v8-debug.h
diff --git a/include/v8-debug.h b/include/v8-debug.h
index
aea5684a8cf73499b3c3ea9f17f430cb441e7d2c..3c738d1a1c814f0f7f186a9460b6ae080ade5986
100644
--- a/include/v8-debug.h
+++ b/include/v8-debug.h
@@ -139,9 +139,6 @@ class V8_EXPORT Debug {
*/
typedef void (*EventCallback)(const EventDetails& event_details);
- // TODO(yangguo) Deprecate this.
- typedef EventCallback EventCallback2;
-
/**
* Debug message callback function.
*
@@ -152,9 +149,6 @@ class V8_EXPORT Debug {
*/
typedef void (*MessageHandler)(const Message& message);
- // TODO(yangguo) Deprecate this.
- typedef MessageHandler MessageHandler2;
-
/**
* Callback function for the host to ensure debug messages are processed.
*/
@@ -163,12 +157,6 @@ class V8_EXPORT Debug {
static bool SetDebugEventListener(EventCallback that,
Handle<Value> data = Handle<Value>());
- // TODO(yangguo) Deprecate this.
- static bool SetDebugEventListener2(EventCallback2 that,
- Handle<Value> data = Handle<Value>())
{
- return SetDebugEventListener(that, data);
- }
-
// Schedule a debugger break to happen when JavaScript code is run
// in the given isolate.
static void DebugBreak(Isolate* isolate);
@@ -192,11 +180,6 @@ class V8_EXPORT Debug {
// Message based interface. The message protocol is JSON.
static void SetMessageHandler(MessageHandler handler);
- // TODO(yangguo) Deprecate this.
- static void SetMessageHandler2(MessageHandler2 handler) {
- SetMessageHandler(handler);
- }
-
static void SendCommand(Isolate* isolate,
const uint16_t* command, int length,
ClientData* client_data = NULL);
Index: src/debug.cc
diff --git a/src/debug.cc b/src/debug.cc
index
87e28f8f15be90f18e69853304ad064a8a7a92bf..8b33087e046b70a66630d0773756571c90a21390
100644
--- a/src/debug.cc
+++ b/src/debug.cc
@@ -2864,8 +2864,8 @@ void Debug::CallCEventCallback(v8::DebugEvent event,
Handle<Object> event_data,
v8::Debug::ClientData* client_data) {
Handle<Foreign> callback_obj(Handle<Foreign>::cast(event_listener_));
- v8::Debug::EventCallback2 callback =
- FUNCTION_CAST<v8::Debug::EventCallback2>(
+ v8::Debug::EventCallback callback =
+ FUNCTION_CAST<v8::Debug::EventCallback>(
callback_obj->foreign_address());
EventDetailsImpl event_details(
event,
Index: test/cctest/test-debug.cc
diff --git a/test/cctest/test-debug.cc b/test/cctest/test-debug.cc
index
a2744be0d8be1c285ff6401b034f05efde7b39b8..cd08df14fa4ae94cf6c9451f811c5105f369d411
100644
--- a/test/cctest/test-debug.cc
+++ b/test/cctest/test-debug.cc
@@ -6647,7 +6647,7 @@ TEST(ProcessDebugMessagesThreaded) {
counting_message_handler_counter = 0;
- v8::Debug::SetMessageHandler2(CountingMessageHandler);
+ v8::Debug::SetMessageHandler(CountingMessageHandler);
send_command_thread_ = new SendCommandThread(isolate);
send_command_thread_->Start();
@@ -6659,7 +6659,7 @@ TEST(ProcessDebugMessagesThreaded) {
CHECK_EQ(100, counting_message_handler_counter);
- v8::Debug::SetMessageHandler2(NULL);
+ v8::Debug::SetMessageHandler(NULL);
CheckDebuggerUnloaded();
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
