Reviewers: Yang,

Message:
Committed patchset #1 manually as r21565 (tree was closed).

Description:
CallIC::PrintState() was incorrectly declared as V8_FINAL.

This broke the windows build.

[email protected]

Committed: https://code.google.com/p/v8/source/detail?r=21565

Please review this at https://codereview.chromium.org/304633004/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+2, -2 lines):
  M src/code-stubs.h


Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index 5fba1cf46b28f42d813cecd4ef7ea2db79161900..520a40509da50a8e5127526ad61dbb85d366aef8 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -818,7 +818,7 @@ class CallICStub: public PlatformCodeStub {

  protected:
   virtual int MinorKey() { return GetExtraICState(); }
-  virtual void PrintState(StringStream* stream) V8_FINAL V8_OVERRIDE;
+  virtual void PrintState(StringStream* stream) V8_OVERRIDE;

   virtual CodeStub::Major MajorKey() { return CallIC; }

@@ -837,7 +837,7 @@ class CallIC_ArrayStub: public CallICStub {
   virtual void Generate(MacroAssembler* masm);

  protected:
-  virtual void PrintState(StringStream* stream) V8_FINAL V8_OVERRIDE;
+  virtual void PrintState(StringStream* stream) V8_OVERRIDE;

   virtual CodeStub::Major MajorKey() { return CallIC_Array; }
 };


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to