Status: Accepted
Owner: ----
CC: [email protected]
Labels: Type-Bug Priority-Medium
New issue 3354 by [email protected]: Inlining heuristics still take
source size into account
http://code.google.com/p/v8/issues/detail?id=3354
InliningAstSize contains the following code:
// Do a quick check on source code length to avoid parsing large
// inlining candidates.
if (target_shared->SourceSize() >
Min(FLAG_max_inlined_source_size, kUnlimitedMaxInlinedSourceSize)) {
TraceInline(target, caller, "target text too big");
return kNotInlinable;
}
https://code.google.com/p/v8/source/browse/trunk/src/hydrogen.cc?r=21543#7280
This check historically made sense because V8 originally did not persist
AST counts on the SharedFunctionInfo. These days however we have
ast_nodes() information directly on the SFI and this heuristic does not
make much sense.
Taking raw source size into account penalizes well-commented short function
in the environments which run unminified code by default (e.g. node.js).
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
