LGTM, although I'm not sure I can foresee all the implications
https://codereview.chromium.org/300893003/diff/40001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/300893003/diff/40001/src/hydrogen-instructions.h#newcode840
src/hydrogen-instructions.h:840: return
!representation().IsSmiOrInteger32() && !representation().IsDouble();
Nit: why not introduce a Number type?
https://codereview.chromium.org/300893003/diff/40001/src/hydrogen-instructions.h#newcode2775
src/hydrogen-instructions.h:2775: :
HTemplateInstruction<2>(HType::HeapObject()), maps_(maps),
Hm, why this?
https://codereview.chromium.org/300893003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
