Mostly looks fine to me, happy to see some C++ code die. Only nits from me.
https://codereview.chromium.org/259883002/diff/120001/src/collection-iterator.js
File src/collection-iterator.js (right):
https://codereview.chromium.org/259883002/diff/120001/src/collection-iterator.js#newcode1
src/collection-iterator.js:1: // Copyright 2014 the V8 project authors.
All rights reserved.
Nit: I think you can use a short license header for this.
https://codereview.chromium.org/259883002/diff/120001/test/mjsunit/harmony/collection-iterator.js
File test/mjsunit/harmony/collection-iterator.js (right):
https://codereview.chromium.org/259883002/diff/120001/test/mjsunit/harmony/collection-iterator.js#newcode2
test/mjsunit/harmony/collection-iterator.js:2: // Redistribution and use
in source and binary forms, with or without
Same nit, short license.
https://codereview.chromium.org/259883002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
