Mostly nits + what about adding a couple of tests that triggers this
optimization as a seed for the fuzzer?
https://codereview.chromium.org/300423003/diff/20001/src/hydrogen-check-elimination.cc
File src/hydrogen-check-elimination.cc (right):
https://codereview.chromium.org/300423003/diff/20001/src/hydrogen-check-elimination.cc#newcode294
src/hydrogen-check-elimination.cc:294: }
Suggestion: What about adding Subtract() method to UniqueSet?
https://codereview.chromium.org/300423003/diff/20001/src/hydrogen-check-elimination.cc#newcode475
src/hydrogen-check-elimination.cc:475: }
Does it make sense to update set of entry maps if the instruction
ensures string or non-string type even if the instruction itself can't
be eliminated?
https://codereview.chromium.org/300423003/diff/20001/src/hydrogen-check-elimination.cc#newcode623
src/hydrogen-check-elimination.cc:623:
instr->block()->MarkSuccEdgeUnreachable(unreachable_succ);
I would suggest to avoid duplication of the three lines above.
https://codereview.chromium.org/300423003/diff/20001/src/hydrogen-check-elimination.h
File src/hydrogen-check-elimination.h (right):
https://codereview.chromium.org/300423003/diff/20001/src/hydrogen-check-elimination.h#newcode31
src/hydrogen-check-elimination.h:31: removed_cho_ = 0;
removed_cit_ = 0;
https://codereview.chromium.org/300423003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
