Revision: 21583
Author:   [email protected]
Date:     Fri May 30 16:12:25 2014 UTC
Log:      HRor and HSar can deoptimize.

BUG=v8:3359
LOG=y
[email protected]

Review URL: https://codereview.chromium.org/309483002
http://code.google.com/p/v8/source/detail?r=21583

Added:
 /branches/bleeding_edge/test/mjsunit/regress/regress-3359.js
Modified:
 /branches/bleeding_edge/src/hydrogen-instructions.cc

=======================================
--- /dev/null
+++ /branches/bleeding_edge/test/mjsunit/regress/regress-3359.js Fri May 30 16:12:25 2014 UTC
@@ -0,0 +1,12 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --allow-natives-syntax
+
+function f() {
+  return 1 >> Boolean.constructor + 1;
+}
+assertEquals(1, f());
+%OptimizeFunctionOnNextCall(f);
+assertEquals(1, f());
=======================================
--- /branches/bleeding_edge/src/hydrogen-instructions.cc Thu May 29 04:13:50 2014 UTC +++ /branches/bleeding_edge/src/hydrogen-instructions.cc Fri May 30 16:12:25 2014 UTC
@@ -831,8 +831,6 @@
     case HValue::kPushArguments:
     case HValue::kRegExpLiteral:
     case HValue::kReturn:
-    case HValue::kRor:
-    case HValue::kSar:
     case HValue::kSeqStringGetChar:
     case HValue::kStoreCodeEntry:
     case HValue::kStoreKeyed:
@@ -877,6 +875,8 @@
     case HValue::kMul:
     case HValue::kOsrEntry:
     case HValue::kPower:
+    case HValue::kRor:
+    case HValue::kSar:
     case HValue::kSeqStringSetChar:
     case HValue::kShl:
     case HValue::kShr:

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to