lgtm, with api change
https://codereview.chromium.org/306053003/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/306053003/diff/1/src/api.cc#newcode6670
src/api.cc:6670: i::Handle<i::CallHandlerInfo> callback_info =
if you're going to reuse the CallHandlerInfo struct, the second field
must be a Handle<Value>.
the embedder can use External::New if needed. this requires no context
https://codereview.chromium.org/306053003/diff/1/src/isolate.cc
File src/isolate.cc (right):
https://codereview.chromium.org/306053003/diff/1/src/isolate.cc#newcode2323
src/isolate.cc:2323: ASSERT(microtask->IsCallHandlerInfo());
no need to assert, ::cast does that
https://codereview.chromium.org/306053003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
