Sorry for the long wait!
The CL (well, original code as well) confuses me a bit. Why do we only
restore
RCX half of the time?
https://codereview.chromium.org/264973011/diff/1/src/x64/macro-assembler-x64.cc
File src/x64/macro-assembler-x64.cc (right):
https://codereview.chromium.org/264973011/diff/1/src/x64/macro-assembler-x64.cc#newcode2148
src/x64/macro-assembler-x64.cc:2148: SmiToInteger32(dst, dst);
Why not just SmiToInteger32(dst, src) ?
https://codereview.chromium.org/264973011/diff/1/src/x64/macro-assembler-x64.cc#newcode2174
src/x64/macro-assembler-x64.cc:2174: SmiToInteger32(dst, dst);
Same here
https://codereview.chromium.org/264973011/diff/1/src/x64/macro-assembler-x64.cc#newcode2192
src/x64/macro-assembler-x64.cc:2192: if (!dst.is(src1)) {
If src1 is rcx, doing SmiToInteger32 first will destroy that register.
https://codereview.chromium.org/264973011/diff/1/src/x64/macro-assembler-x64.cc#newcode2216
src/x64/macro-assembler-x64.cc:2216: shll_cl(dst);
Seems like this code could be simplified? Why didn't we need to restore
rcx above?
https://codereview.chromium.org/264973011/diff/1/src/x64/macro-assembler-x64.cc#newcode2252
src/x64/macro-assembler-x64.cc:2252: movp(dst, src1);
SmiToInteger32(dst, src1);
https://codereview.chromium.org/264973011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
