Updated
https://codereview.chromium.org/297303006/diff/1/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/297303006/diff/1/src/debug.cc#newcode604
src/debug.cc:604: heap->CollectAllGarbage(Heap::kNoGCFlags,
"Debug::CreateScriptCache");
On 2014/05/28 13:24:32, ulan wrote:
The comment is out of sync: there is only one GC and the heap is not
iterable
afterwards.
If incremental marking is in progress then this will not trigger old
space GC.
The comment actually makes sense:
Script wrappers are weak global handles. The first GC needs to trigger
their weak callbacks. The second one then removes dead script objects.
Both have to be done here because HeapIterator only does a GC if the
heap is not yet iterable.
I'm not entirely sure whether the first GC has be to
kMakeHeapIterableMask or just kSweepPreciselyMask though.
https://codereview.chromium.org/297303006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
