https://codereview.chromium.org/309623007/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/309623007/diff/1/src/heap.cc#newcode1304
src/heap.cc:1304: changed_to_max_semi_space_size_ = true;
On 2014/06/02 13:31:25, mvstanton wrote:
Is the boolean really needed? Why not just ask
new_space_.IsAtMaximumCapacity().
I'm thinking it might be some redundant/duplicate state.
As discussed offline, we need a separate flag to identify valid
pretenuring feedback
https://codereview.chromium.org/309623007/diff/1/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/309623007/diff/1/src/objects-inl.h#newcode1586
src/objects-inl.h:1586: if (heap->changed_to_max_semi_space_size() &&
On 2014/06/02 13:31:25, mvstanton wrote:
Since the allocation sites are processed in bulk, and this predicate
(changed_to_max_semi_space_size()) won't change between the start of
the
processing and the end of it, it might be better to pass that value in
to
DigestPretenuringFeedback().
What do you think? This might also reduce the need for a boolean
versus a
predicate that just checks the space capacity against max capacity.
Done.
https://codereview.chromium.org/309623007/diff/1/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/309623007/diff/1/test/cctest/test-heap.cc#newcode2198
test/cctest/test-heap.cc:2198: i::FLAG_min_semi_space_size = 8;
On 2014/06/02 13:31:25, mvstanton wrote:
Why is this being done? Probably worth a comment.
Done.
https://codereview.chromium.org/309623007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
