On 2014/06/02 12:52:37, jbramley wrote:
https://codereview.chromium.org/308023007/diff/1/src/checks.h
File src/checks.h (right):
https://codereview.chromium.org/308023007/diff/1/src/checks.h#newcode34
src/checks.h:34: #if V8_TARGET_ARCH_ARM64 && !V8_HOST_ARCH_ARM64
On 2014/06/02 12:48:56, ulan wrote:
> I think this branch is now active for cross-compiled binaries that do
not
> necessarily use simulator.
You might be right, but that is how USE_SIMULATOR is defined in globals.h.
I'll
do a cross-build and see what happens.
Ok, my first patch was broken, as you noted. V8_TARGET_ARCH_ARM64 and
V8_HOST_ARCH_ARM64 are the right macros to use (even for cross builds), but
V8_HOST_ARCH_ARM64 is defined automatically in base/build_config.h, and
isn't
defined by this point in src/checks.h. I've uploaded a new patch that
includes
this header, and it now behaves as expected.
https://codereview.chromium.org/308023007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
