Done
https://codereview.chromium.org/309663005/diff/40001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/309663005/diff/40001/src/objects.cc#newcode16552
src/objects.cc:16552: Handle<Object> value) {
On 2014/06/02 13:34:04, Michael Starzinger wrote:
nit: Can we add an assertion here checking that "value" is not the
hole?
Done.
https://codereview.chromium.org/309663005/diff/40001/test/cctest/test-dictionary.cc
File test/cctest/test-dictionary.cc (right):
https://codereview.chromium.org/309663005/diff/40001/test/cctest/test-dictionary.cc#newcode66
test/cctest/test-dictionary.cc:66:
On 2014/06/02 13:34:04, Michael Starzinger wrote:
nit: Let's add a comment along the lines of ...
// Keys that have been removed are mapped to the hole value.
Done.
https://codereview.chromium.org/309663005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
