Reviewers: Raymond Toy,
https://codereview.chromium.org/303753002/diff/40001/src/math.js
File src/math.js (right):
https://codereview.chromium.org/303753002/diff/40001/src/math.js#newcode262
src/math.js:262: }
On 2014/06/02 17:26:11, Raymond Toy wrote:
As you mentioned via email, you've removed the 3rd iteration. This is
really
needed if you want to be able to reduce multiples of pi/2 accurately.
That's true. However, the reduction step is not exposed as a library
function. From what I have seen, the third step seems to only affect y1.
With a y0 really close to y1, it does not change the result of sine or
cosine. This is also why I was asking for a test case where removing
this third step would make a difference.
Description:
Trigonometric functions using fdlibm.
BUG=v8:3006
LOG=N
Please review this at https://codereview.chromium.org/303753002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+655, -281 lines):
M src/bootstrapper.cc
M src/math.js
A src/rempio2.h
A src/rempio2.cc
M src/runtime.h
M src/runtime.cc
D src/trig-table.h
A + test/mjsunit/runtime-gen/rempio2.js
M test/mjsunit/sin-cos.js
M tools/generate-runtime-tests.py
D tools/generate-trig-table.py
M tools/gyp/v8.gyp
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
