LGTM with comments
https://codereview.chromium.org/310063002/diff/1/test/cctest/cctest.h
File test/cctest/cctest.h (right):
https://codereview.chromium.org/310063002/diff/1/test/cctest/cctest.h#newcode451
test/cctest/cctest.h:451: CHECK(result->Equals(expected));
Not your CL really, but shouldn't this use SameValue, or at least
StrictEquals?
https://codereview.chromium.org/310063002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/310063002/diff/1/test/cctest/test-parsing.cc#newcode2474
test/cctest/test-parsing.cc:2474: "function not_lazy_not_ctor() { "
How does this differ from the previous?
https://codereview.chromium.org/310063002/diff/1/test/cctest/test-parsing.cc#newcode2496
test/cctest/test-parsing.cc:2496: ExpectString("Ctor()", "Ctor.foo5");
Wow...
https://codereview.chromium.org/310063002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
