Reviewers: jarin,
Message:
PTAL
Description:
Fix invalid loop condition for Array.lastIndexOf().
BUG=380512
LOG=y
Please review this at https://codereview.chromium.org/313073003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+6, -10 lines):
M src/hydrogen.cc
A + test/mjsunit/regress/regress-crbug-380512.js
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index
39554993d8c39144801849a0a1c83aa9ba046c73..aedf3a10e9600efa74214903928fdc406593e9a2
100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -8385,7 +8385,7 @@ HValue*
HOptimizedGraphBuilder::BuildArrayIndexOf(HValue* receiver,
ASSERT_EQ(kLastIndexOf, mode);
initial = length;
terminating = graph()->GetConstant0();
- token = Token::GTE;
+ token = Token::GT;
direction = LoopBuilder::kPreDecrement;
}
Index: test/mjsunit/regress/regress-crbug-380512.js
diff --git a/test/mjsunit/regress/regress-alloc-smi-check.js
b/test/mjsunit/regress/regress-crbug-380512.js
similarity index 72%
copy from test/mjsunit/regress/regress-alloc-smi-check.js
copy to test/mjsunit/regress/regress-crbug-380512.js
index
295048a13ef862ceb21939de104e7968dd7772da..af78ba7183abebad0178de169592c276f95f03c7
100644
--- a/test/mjsunit/regress/regress-alloc-smi-check.js
+++ b/test/mjsunit/regress/regress-crbug-380512.js
@@ -1,16 +1,12 @@
// Copyright 2014 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-//
-// Flags: --allow-natives-syntax
-var x = {};
+// Flags: --allow-natives-syntax
-function f(a) {
- a[200000000] = x;
-}
+function f() { [].lastIndexOf(42); }
-f(new Array(100000));
-f([]);
+f();
+f();
%OptimizeFunctionOnNextCall(f);
-f([]);
+f();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
