Updates:
Status: Assigned
Owner: [email protected]
Comment #2 on issue 3367 by [email protected]: Bounds check elimination
does not work for constant indices
http://code.google.com/p/v8/issues/detail?id=3367
suggested fix: https://codereview.chromium.org/310333004/
Resulting code:
0x23a4dd77 23 8b059c85d04c mov eax,[0x4cd0859c] ;; property
cell
0x23a4dd7d 29 8178ffb9e8903b cmp [eax-0x1],0x3b90e8b9 ;; object:
0x3b90e8b9 <Map(elements=24)>
0x23a4dd84 36 0f85b3000000 jnz 221 (0x23a4de3d)
0x23a4dd8a 42 8b05a485d04c mov eax,[0x4cd085a4] ;; property
cell
0x23a4dd90 48 8b4007 mov eax,[eax+0x7]
0x23a4dd93 51 8b4803 mov ecx,[eax+0x3]
0x23a4dd96 54 83f90e cmp ecx,0xe
0x23a4dd99 57 0f86a3000000 jna 226 (0x23a4de42)
0x23a4dd9f 63 83f900 cmp ecx,0x0
0x23a4dda2 66 0f869f000000 jna 231 (0x23a4de47)
0x23a4dda8 72 f20f10483f movsd xmm1,[eax+0x3f]
0x23a4ddad 77 f20f105037 movsd xmm2,[eax+0x37]
0x23a4ddb2 82 f20f59d1 mulsd xmm2,xmm1 ;; debug:
position 104
0x23a4ddb6 86 f20f10482f movsd xmm1,[eax+0x2f]
0x23a4ddbb 91 f20f59ca mulsd xmm1,xmm2 ;; debug:
position 111
0x23a4ddbf 95 f20f105027 movsd xmm2,[eax+0x27]
0x23a4ddc4 100 f20f59d1 mulsd xmm2,xmm1 ;; debug:
position 118
0x23a4ddc8 104 f20f10481f movsd xmm1,[eax+0x1f]
0x23a4ddcd 109 f20f59ca mulsd xmm1,xmm2 ;; debug:
position 125
0x23a4ddd1 113 f20f105017 movsd xmm2,[eax+0x17]
0x23a4ddd6 118 f20f59d1 mulsd xmm2,xmm1 ;; debug:
position 132
0x23a4ddda 122 f20f10480f movsd xmm1,[eax+0xf]
0x23a4dddf 127 f20f59ca mulsd xmm1,xmm2 ;; debug:
position 139
0x23a4dde3 131 f20f105007 movsd xmm2,[eax+0x7]
0x23a4dde8 136 f20f59d1 mulsd xmm2,xmm1 ;; debug:
position 146
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
