https://codereview.chromium.org/307593002/diff/20001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/307593002/diff/20001/src/ast.h#newcode444
src/ast.h:444: const BailoutId DeclsId() const { return decls_id_; }
On 2014/06/04 12:54:53, rossberg wrote:
nit: the first const here does not have any meaning.
Done.
https://codereview.chromium.org/307593002/diff/20001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/307593002/diff/20001/src/hydrogen.cc#newcode4283
src/hydrogen.cc:4283: set_scope(scope);
On 2014/06/04 12:54:53, rossberg wrote:
Hm, can pushing/popping the scope perhaps be factored into
BreakAndContinueScope, or a separate BlockScope abstraction?
Done.
https://codereview.chromium.org/307593002/diff/20001/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/307593002/diff/20001/src/ia32/lithium-codegen-ia32.cc#newcode5673
src/ia32/lithium-codegen-ia32.cc:5673:
CallRuntime(Runtime::kHiddenPushBlockContext, 2, instr);
Right, we will do it sooner than later. Leaving it as it is.
https://codereview.chromium.org/307593002/diff/20001/test/mjsunit/harmony/block-let-crankshaft.js
File test/mjsunit/harmony/block-let-crankshaft.js (right):
https://codereview.chromium.org/307593002/diff/20001/test/mjsunit/harmony/block-let-crankshaft.js#newcode36
test/mjsunit/harmony/block-let-crankshaft.js:36: f27, f28, f29, f30,
f31, f32, f33 ];
On 2014/06/04 12:54:53, rossberg wrote:
Perhaps add a test for throwing out of a crankshaft'ed function inside
a nested
block, just in case.
Done.
https://codereview.chromium.org/307593002/diff/20001/test/mjsunit/harmony/block-scoping.js
File test/mjsunit/harmony/block-scoping.js (right):
https://codereview.chromium.org/307593002/diff/20001/test/mjsunit/harmony/block-scoping.js#newcode31
test/mjsunit/harmony/block-scoping.js:31: // TODO(ES6): properly
activate extended mode
On 2014/06/04 12:54:53, rossberg wrote:
Btw, we can remove this TODO now.
Done.
https://codereview.chromium.org/307593002/diff/20001/test/mjsunit/harmony/block-scoping.js#newcode67
test/mjsunit/harmony/block-scoping.js:67:
On 2014/06/04 12:54:53, rossberg wrote:
Why not assert optimization status here as well (and below)?
Did it for the function below. This function doesn't get optimized
because of eval, so I removed %OptimizeFunctionOnNextCall for it.
https://codereview.chromium.org/307593002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
